Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add underscore thousands separators to numeric values #202

Open
MaxGhenis opened this issue Dec 30, 2022 · 1 comment · May be fixed by #204
Open

Option to add underscore thousands separators to numeric values #202

MaxGhenis opened this issue Dec 30, 2022 · 1 comment · May be fixed by #204
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MaxGhenis
Copy link

yaml ignores underscores in numbers, so these are equivalent. I use the underscores for readability with large numbers. It'd be nice to have this as an option in yamlfix.

key1: 1435498
key2: 1_435_498
@lyz-code
Copy link
Owner

Hi @MaxGhenis , thank you for taking the time to open the issue. This shouldn't be very difficult to implement, would you be willing to make a pull request? I can guide you if you need.

Thanks

@lyz-code lyz-code added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 30, 2022
@marcules marcules linked a pull request Jan 1, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable underscore integer separation for decimal values (ints) marcules/yamlfix
2 participants
@MaxGhenis @lyz-code