Faster HC #471
Merged
Faster HC #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by removing bad candidates faster.
by optimizing countback
terrelln
approved these changes
Feb 20, 2018
lib/lz4hc.c
Outdated
| @@ -220,20 +222,10 @@ LZ4_FORCE_INLINE int LZ4HC_InsertAndGetWiderMatch ( | |||
| nbAttempts--; | |||
| if (matchIndex >= dictLimit) { | |||
| const BYTE* const matchPtr = base + matchIndex; | |||
| if (*(iLowLimit + longest) == *(matchPtr - delta + longest)) { | |||
| if (LZ4_read16(iLowLimit + longest - 1) == LZ4_read16(matchPtr - delta + longest - 1)) { | |||
There was a problem hiding this comment.
Can you add an assert(longest >= 1);?
suggested by @terrelln
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These little changes speed up a bit Hash Chain match finder.
On my laptop, using
clang:before :
after :