Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook-katex2 and thank you #37

Closed
SichangHe opened this issue Nov 22, 2022 · 6 comments
Closed

mdbook-katex2 and thank you #37

SichangHe opened this issue Nov 22, 2022 · 6 comments

Comments

@SichangHe
Copy link
Collaborator

SichangHe commented Nov 22, 2022

I forked this project and created mdbook-katex2. It is now also on crates.io.

Users of mdbook-katex are welcomed to use mdbook-katex2. It provides the same functionality and I will try to keep it maintained.

I want to thank @lzanini, @Matthewacon, @kknives, @Luni-4, @lovesegfault, @srevinsaju and all the other people who helped with mdbook-katex. I will try to continue your good work. Please criticize if you wish.

@lzanini
Copy link
Owner

lzanini commented Nov 22, 2022

Hi @SichangHe, Indeed I didn't find the time to deal with this project's issues these last months. I'd be happy to add you as a collaborator to this project, which might be simpler for people already using the tools and for future users. I added you on twitter in case you want to discuss this.

@SichangHe
Copy link
Collaborator Author

@lzanini thank you for responding! Sorry for thinking that you are not around…
It would be nicer if you can contact me via email: stevensichanghe@gmail.com
I don't check Twitter despite having an account.

@SichangHe
Copy link
Collaborator Author

I have received neither message on Twitter nor email 😔. I will continue to assume that you are too busy to attend to.
Meanwhile, I will do what I can do in mdbook-katex2.

@SichangHe
Copy link
Collaborator Author

I have received invitation from @lzanini to be a collaborator and accepted it.
To merge the changes I made to mdbook-katex2 back, I made a new branch and a pull request #38.
The new branch passes all tests, fmt, and clippy, the deploy build CI also seemed to work on mdbook-katex2. But, I don't know if the publish CI works.

@lzanini, should I wait for someone to look at it or should I just approve it and fix any mistakes afterwards?

@lzanini
Copy link
Owner

lzanini commented Nov 24, 2022

Let's merge your changes and update the CI afterwards if needed !

@SichangHe
Copy link
Collaborator Author

I have started to maintain mdbook-katex and deprecated mdbook-katex2.
For future people, please continue to use mdbook-katex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants