Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI feedback after upload + allow user to retry upload #119

Merged
merged 9 commits into from
Jul 9, 2020

Conversation

robertodauria
Copy link
Contributor

This PR makes quite a few changes to the extension:

  • The Upload feature is now configurable via a new section in the Settings
  • If the upload is enabled, it will attempt to upload the new measurement at the end of a test, displaying the result to the user
  • If the upload has failed, it's possible to retry uploading old measurements from the "Explore Data" section, by opening the contextual menu on each entry (swiping to the left) and clicking the upload icon.

@robertodauria robertodauria requested a review from critzo July 9, 2020 11:20
Copy link

@critzo critzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @robertodauria
One question about the ability to attempt upload again if it initially fails. I see you're enabling a manual upload button on results that weren't uploaded originally. That's cool. Is it possible for the upload service to automatically upload previously un-uploadable results? Maybe the next time it tries uploading a new result? If not, that's ok, I just wonder about automating that instead of just relying on a user to take action.

@robertodauria
Copy link
Contributor Author

Discussed on Slack. The short summary is: it can be done, but we need either to preserve compatibility with older measurements or exclude them from this feature somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants