Connection ID fallback and Docker Compose support #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1050
💛 - Coveralls |
bassosimone
suggested changes
Oct 22, 2019
gen_local_test_certs.sh
Outdated
| @@ -1,6 +1,7 @@ | |||
| #!/bin/bash | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Can you test whether this works with dash and ksh? I believe the main reason why it was named bash and it was invoking explicitly bash is because it is using the non-portable set -euxo pipefail.
There was a problem hiding this comment.
You're correct, it doesn't work under Dash. I'm switching the interpreter back to Bash and updating Dockerfile.local to install Bash.
bassosimone
approved these changes
Oct 22, 2019
|
Will merge when Travis becomes green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the ID fallback in
fdcachebecause them-lab/uuidappears to function as a wrapper for getting an ID via the TCP connections SO_COOKIE and I don't think it makes sense to muddy that package with fallback support.The PR also adds support for Docker Compose. The
Dockerfile.localis used bydocker-compose.ymlbecause the mainDockerfiledoesn't copygen_local_test_certs.shinto the image. I also switchgen_local_test_certs.shto use /bin/sh as I'm pretty sure Alpine Linux doesn't include Bash. I also added the cert moving into the script.This change is