API CHANGE: NewClient(clientName, clientVersion) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the NewClient API to take two arguments, the
clientName and the clientVersion, instead of a userAgent.
We didn't specify how userAgent was made. In theory we expected it
to be composed of `${clientName}/${clientVersion}` but that was not
enforced in any way. Per #16, we want the client to identify with
the server also using the query string.
This is for consistency with what the JavaScript client does.
While there, also provide information on the OS and the architecture
of the client, again as part of the query string.
Closes #16.
|
Please resolve the conflicts? |
|
Sure! |
|
@pboothe done! |
pboothe
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the NewClient API to take two arguments, the
clientName and the clientVersion, instead of a userAgent.
We didn't specify how userAgent was made. In theory we expected it
to be composed of
${clientName}/${clientVersion}but that was notenforced in any way. Per #16, we want the client to identify with
the server also using the query string.
This is for consistency with what the JavaScript client does.
While there, also provide information on the OS and the architecture
of the client, again as part of the query string.
Closes #16.