Implement unencrypted ndt7 (+other maintainance changes) #31
Conversation
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @bassosimone and @pboothe)
cmd/ndt7-client/main.go, line 98 at r1 (raw file):
flagNoVerify = flag.Bool("no-verify", false, "skip TLS certificate verification") flagHostname = flag.String("hostname", "", "optional ndt7 server hostname") flagScheme = flag.String(
Consider making this a custom flag type to ensure that the scheme can only be one of the specified legal values?
|
Added one comment. If you don't want to do it, let me know and I will approve this PR. |
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe)
cmd/ndt7-client/main.go, line 98 at r1 (raw file):
Previously, pboothe (Peter Boothe) wrote…
Consider making this a custom flag type to ensure that the scheme can only be one of the specified legal values?
Good idea! I'll try to use github.com/m-lab/flagx for this purpose!
Allows to narrow down the allowed values to ws and wss as suggested by @pboothe during the review.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained
complete! 1 of 1 approvals obtained
This change is