Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use NewJSON #41

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Only use NewJSON #41

merged 1 commit into from
Feb 14, 2020

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Feb 14, 2020 •
edited
Loading

I miscommunicated, so now I pay the price.

This eliminates NewJSONWithWriter in favor of NewJSON. main() can pass in os.Stdout just fine, and this change simplifies both testing and naming.

This change is Reviewable

robertodauria
robertodauria approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - I think you communicated just fine, I misjudged whether keeping a NewJSON() purely for convenience was a good idea or not. Thank you!

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)

@pboothe pboothe merged commit 496e7c2 into master Feb 14, 2020
@pboothe pboothe deleted the normalize-newjson branch February 14, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertodauria robertodauria robertodauria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pboothe @robertodauria