Updates EtcdOverview dashboard to use the new name for a metric #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes/kubernetes#99785 The PR says the new metric name will be apiserver_storage_object_counts, but on a running v1.21.14 control plane node, the metric is actually named apiserver_storage_ojects.
stephen-soltesz
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the k8s v1.21.0 changelog I noted that one particular metric was changing names:
The CS in this PR seems large, but almost all of it is nothing more than Grafana updating the JSON model a good deal since when the dashboard was first created. The meaningful change is using the metric
apiserver_storage_objectsinstead of the now deprecatedetcd_object_counts.This change is