Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors main() to use memoryless #17

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Jan 9, 2019

Also converts the delay constants into command-line flags so that they can be set by commandline flag if desired using the nice duration syntax that Go supports.


This change is Reviewable

Also converts the delay constants into command-line flags so that they
can be set by flag if desired using the nice duration sysntax that Go
supports.
Copy link

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: -- wait for @evfirerob to give final approval.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @stephen-soltesz and @evfirerob)

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: -- Looks great! Regarding the TODO: It's important that the nodes have time to reboot, 15 seemed quite safe. We can probably increase the default maxsleeptime without any particular side effect.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stephen-soltesz)

@pboothe pboothe merged commit f64cba2 into master Jan 9, 2019
@pboothe pboothe deleted the refactor-using-memoryless branch January 9, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants