Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new tcpinfo fields #123

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Add two new tcpinfo fields #123

merged 2 commits into from
Sep 10, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Sep 10, 2020

This adds two new fields that have been added in linux kernel to the corresponding message struct.

Parser will pick this up the next time we build or deploy etl.


This change is Reviewable

@coveralls
Copy link

coveralls commented Sep 10, 2020

Pull Request Test Coverage Report for Build 899

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.873%

Totals Coverage Status
Change from base Build 894: 0.0%
Covered Lines: 1079
Relevant Lines: 1302

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked using https://lxr.missinglinkelectronics.com/linux/include/uapi/linux/tcp.h#L274

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 removed the request for review from mattmathis September 10, 2020 18:55
Copy link
Contributor Author

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated header comment with the reference that Matt suggested.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants