Skip to content

Commit

Permalink
bank: remove RE signal for field registers
Browse files Browse the repository at this point in the history
  • Loading branch information
Sebastien Bourdeauducq committed Oct 9, 2012
1 parent e410973 commit 8508179
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions migen/bank/csrgen.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@ def get_fragment(self):
self.interface.we & \
(self.interface.adr[:nbits] == Constant(i, BV(nbits)))))
elif isinstance(reg, RegisterFields):
sync.append(reg.re.eq(0))
bwra = [Constant(i, BV(nbits))]
offset = 0
for field in reg.fields:
if field.access_bus == WRITE_ONLY or field.access_bus == READ_WRITE:
bwra.append(field.storage.eq(self.interface.dat_w[offset:offset+field.size]))
offset += field.size
if len(bwra) > 1:
bwra.append(reg.re.eq(1))
bwcases.append(bwra)
# commit atomic writes
for field in reg.fields:
Expand Down
8 changes: 2 additions & 6 deletions migen/bank/description.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,9 @@ def __init__(self, name, size=1, access_bus=READ_WRITE, access_dev=READ_ONLY, re
self.we = Signal()

class RegisterFields:
def __init__(self, name, fields, re=None):
def __init__(self, name, fields):
self.name = name
self.fields = fields
if re is None:
self.re = Signal()
else:
self.re = re

class RegisterField(RegisterFields):
def __init__(self, name, size=1, access_bus=READ_WRITE, access_dev=READ_ONLY, reset=0, atomic_write=False):
Expand Down Expand Up @@ -111,7 +107,7 @@ def expand_description(description, busword):
else:
f.append(field)
if f:
d.append(RegisterFields(reg.name, f, reg.re))
d.append(RegisterFields(reg.name, f))
else:
raise TypeError
return d

0 comments on commit 8508179

Please sign in to comment.