Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17 (Add a more user-friendly error message when the yosys binary can't be found) #19

Closed
wants to merge 1 commit into from

Conversation

the6p4c
Copy link

@the6p4c the6p4c commented Jan 1, 2019

Should fix #17.

Not sure if this is the error message format you'd like, couldn't find any examples of raising a similar error. Keeps the original FileNotFound error intact by chaining the RuntimeError to it.

Tested on both Linux and Windows.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files          19       19           
  Lines        2884     2884           
  Branches      625      625           
=======================================
  Hits         2345     2345           
  Misses        497      497           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7e19e...b1f54b8. Read the comment docs.

@whitequark
Copy link
Contributor

Added an even better error in 06faeee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a more user-friendly error message when the yosys binary can't be found
2 participants