Change name seperator for siganls in records to double underscore #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
======================================
Coverage 85.5% 85.5%
======================================
Files 27 27
Lines 3912 3912
Branches 764 764
======================================
Hits 3345 3345
Misses 478 478
Partials 89 89
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the seperator for signal names in records from a single underscore to a double underscore. When creating a Record, the signals inside it are then named
recordname__fieldname.This gives one more useful information, when looking at the signal names of fields which themselves contain underscores. E.g.
record__some_fieldis now unambiguous :)It closes #48.