Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature of measuring extendability. #8

Merged
merged 37 commits into from
Dec 24, 2021
Merged

Conversation

fatemehkarimi
Copy link
Contributor

No description provided.

fatemehkarimi and others added 29 commits November 18, 2021 13:20
Copy link
Owner

@m-zakeri m-zakeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- Follow PEP instructions for naming python entities, specifically module names:
https://www.python.org/dev/peps/pep-0008/

2- Merge main.py to extendibility,py for better consistency

3- Ensure fixing issues discussed in presentation session

@m-zakeri
Copy link
Owner

ToDo:
1- Follow PEP instructions for naming python entities, specifically module names:
https://www.python.org/dev/peps/pep-0008/
2- Merge main.py to extendibility.py for better consistency
@fatemehkarimi @niloofarizadyar

@fatemehkarimi
Copy link
Contributor Author

@m-zakeri
I know that camelCase should not be used according to PEP 8, but ANTLR uses camelCase naming convention, and I did so to be consistent with it. do you accept this explanation or I should change the names?

@m-zakeri
Copy link
Owner

@m-zakeri I know that camelCase should not be used according to PEP 8, but ANTLR uses camelCase naming convention, and I did so to be consistent with it. do you accept this explanation or I should change the names?

I think we should not repeat others' mistakes.
Also, please address my second commnet.

@m-zakeri m-zakeri self-requested a review December 18, 2021 08:38
@fatemehkarimi
Copy link
Contributor Author

@m-zakeri The branch is ready.
please merge

@m-zakeri m-zakeri merged commit 7b103af into m-zakeri:main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants