Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix setup.py so that new 'api' module directory is included in package #4

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Conversation

svet-b
Copy link
Contributor

@svet-b svet-b commented Oct 5, 2018

The newly released v0.3.1 package cannot actually be imported after installation:

>>> import grafana_api
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/grafana_api-0.3.1-py3.6.egg/grafana_api/__init__.py", line 1, in <module>
    from .grafana_face import GrafanaFace
  File "/usr/local/lib/python3.6/site-packages/grafana_api-0.3.1-py3.6.egg/grafana_api/grafana_face.py", line 2, in <module>
    from .api import Base
ModuleNotFoundError: No module named 'grafana_api.api'

This is because the .api submodule is not actually included in the package. In order for it to be included, it needs to be explicitly listed in setup.py. This PR should address this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.468% when pulling 0ea3f31 on svet-b:fix_setup into b9784a3 on m0nhawk:master.

@m0nhawk m0nhawk merged commit ccdb59b into m0nhawk:master Oct 6, 2018
@m0nhawk
Copy link
Owner

m0nhawk commented Oct 6, 2018

Thank you for help and fix on this!

m0nhawk added a commit that referenced this pull request Oct 6, 2018
Fix setup.py so that new 'api' module directory is included in package
m0nhawk added a commit that referenced this pull request Oct 28, 2018
Fix setup.py so that new 'api' module directory is included in package
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants