Address chaining issues by making state management more predictable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
INSChainOperationquite heavily, and was experiencing an issue when adding lots of these operations to a queue. After a while the queue would stop processing operations.I've got a project that reproduces the issue here: https://github.com/craigmarvelley/insoperationskit-chaining-issues
A similar issue was reported on the PSOperations repo (pluralsight/PSOperations#32). I applied the equivalent fix there to this repo, and brought over some additional fixes to the operation class' state management that have been added to PSOperations recently (locking the property while updating, etc.).
After applying these fixes and using the code heavily over the last month I'm no longer seeing my queries stop processing operations.