Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Blog creation #21

Merged
merged 1 commit into from
Sep 24, 2018
Merged

[WIP] Blog creation #21

merged 1 commit into from
Sep 24, 2018

Conversation

el00ruobuob
Copy link
Contributor

This is a work in progress, will be updated soon.

@el00ruobuob el00ruobuob changed the title [WIP][Do Not Merge] Blog creation [WIP] Blog creation Aug 28, 2018
@el00ruobuob
Copy link
Contributor Author

It's working fine. Let's work on the look&feel @rehrar & @m2049r as this is very basic at the moment.

@el00ruobuob
Copy link
Contributor Author

I'm not sure if we need a "tag" thing or not. let's discuss it.

@rehrar
Copy link
Contributor

rehrar commented Aug 31, 2018

No, the tag is not necessary for now. It can be painlessly added later. Let's see if this is used period.

@el00ruobuob
Copy link
Contributor Author

tag removed. Have you tried building it @rehrar?

@rehrar
Copy link
Contributor

rehrar commented Sep 21, 2018

@el00ruobuob can you rebase? :) Let's get this merged.

@el00ruobuob
Copy link
Contributor Author

Rebased and updated with French strings, since French translation has been merged.

@rehrar
Copy link
Contributor

rehrar commented Sep 21, 2018

legit, thank you

Copy link
Owner

@m2049r m2049r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • i am not sure i like the way "Resources" drops to a second line - is that really necessary?

  • when "in" the blog section, you can't get out. i.e. all header links ("Features" etc.) remain in the blog namespace.

@el00ruobuob
Copy link
Contributor Author

I may have screwed in rebasing. I know where the namespace bug came from, I took the wrong part, and should have choose ours instead of their. I'll give it an update in a moment.

@el00ruobuob
Copy link
Contributor Author

Could you give a try to this latest commit @m2049r ?

@el00ruobuob
Copy link
Contributor Author

el00ruobuob commented Sep 22, 2018

The resources on next line was a CSS glitch, it's corrected now.
let me know @rehrar if setting the col-sm-5 at 35% and col-sm-7 at 65% is a problem.
Edit: col-sm-5 at 30% and col-sm-7 at 70% because of French long words.

@m2049r
Copy link
Owner

m2049r commented Sep 23, 2018

looks much better @el00ruobuob.

two suggestions:

  • when there are multiple blog entries, the summary of the previous one is stuck to the title of the next one, with a lot of space between title & summary. this would probably be ok, but not if there is no space to the next title item)
  • could we show the blog dates in the list of entries?

@el00ruobuob
Copy link
Contributor Author

I'll look at this, both seems easy to do.

@el00ruobuob
Copy link
Contributor Author

Hi @m2049r, i did a few tweaks and it seems to look fine.
Let me know if it suits your needs.

@m2049r
Copy link
Owner

m2049r commented Sep 24, 2018

nice 👍

@m2049r m2049r merged commit ffd3379 into m2049r:master Sep 24, 2018
@m2049r
Copy link
Owner

m2049r commented Sep 24, 2018

@el00ruobuob i had to change the navigation links to blog.html so it works on apache (monerujo.app) as well. it was a problem because there is also a blog folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants