Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect old to new CD update site? #143

Closed
vorburger opened this issue Sep 19, 2018 · 8 comments
Closed

Redirect old to new CD update site? #143

vorburger opened this issue Sep 19, 2018 · 8 comments

Comments

@vorburger
Copy link
Member

further to #137 re. our old VS new p2 update site:

seeing @antoine-morvan link to https://github.com/preesm/m2e-code-quality/commit/2a3742207f799bfb20e2897e217ace5ee2be8894 in #120 (comment) (thanks), I'm wondering if the same p2 redirect <child location= thing in compositeArtifacts.xml should somehow be done to https://github.com/m2e-code-quality/m2e-code-quality/tree/gh-pages/site ? Perhaps preserve old versions there as is, but make anyone grabbing the latest one redirect to https://m2e-code-quality.github.io/m2e-code-quality-p2-site/ ?

My p2 understanding is too rusty to know exactly how to do that, but if @antoine-morvan would contribute a PR ... that could be cool, and will perhaps avoid some confusion in the future to people.

@erwint @victornoel @ArloL thoughts - any reason why we should not do this that I cannot think of?

@victornoel
Copy link
Contributor

@vorburger I agree it' a good idea, but I can't help in practice, I've never understood how all those things worked in p2, I tried, but I never succeeded :P

@antoine-morvan
Copy link
Contributor

Hey, I'll have a look at this (I'll let you change the index.html files with proper guidelines).

Basically you want the old P2 repo to serve the current releases it has (that is pre-Photon compatible) plus the new repo with Photon+ compatible, right ?

@vorburger
Copy link
Member Author

I'll let you change the index.html files with proper guidelines

#144

Basically you want the old P2 repo to serve the current releases it has (that is pre-Photon compatible) plus the new repo with Photon+ compatible, right ?

Yeah. Except that I assumed that the new repo is also still compatible pre-Photon... I didn't think we already broke that? 😄

@vorburger
Copy link
Member Author

the new repo with Photon+ compatible, right ?

@antoine-morvan FYI @pgalbraith has done some compatiblity testing, see #123 (comment).

erwint pushed a commit that referenced this issue Sep 19, 2018
…o make it more of an open community (#144)

for full background,
see also #123
and #124
and #143
@antoine-morvan
Copy link
Contributor

Yeah my bad, I meant the old repo is pre-photon only and the new is pre+post photon compatible.

Do you also want the new repo to serve the releases from the old one ?

@vorburger
Copy link
Member Author

Do you also want the new repo to serve the releases from the old one ?

yeah, but as per #155

@erwint
Copy link
Member

erwint commented Nov 10, 2018

Should be fixed now that #155 is merged. Can we close this?

@vorburger
Copy link
Member Author

Should be fixed now that #155 is merged. Can we close this?

yep! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants