Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Checkstyle URL breaks Oomph setup #251

Closed
famod opened this issue Jul 6, 2021 · 5 comments
Closed

Wrong Checkstyle URL breaks Oomph setup #251

famod opened this issue Jul 6, 2021 · 5 comments

Comments

@famod
Copy link
Contributor

famod commented Jul 6, 2021

We have (well, had) this in our project Oomph setup file:
P2

Due to the demise of bintray, this brings in now broken update sites for eclipse-cs (and with 1.1.4.201906210825-r also pmd), which in turn breaks "Check for Updates" or "Perform Setup Tasks..." (when P2 Directors are run).
Removing those broken sites is of no real use since they come back with each "Perform Setup Tasks...".

As a quick hack I did the following and lo and behold, it worked: develop...famod:fix-urls
Changes:

Take this with a grain of salt because I didn't run any tests (-DskipTests).

@vorburger
Copy link
Member

Why not directly raise a PR instead of a bug?

Would you be interested to be invited as a committer to this project to help maintain it?

@famod
Copy link
Contributor Author

famod commented Jul 10, 2021

Why not directly raise a PR instead of a bug?

Because I didn't run any tests and I'm lacking the knowledge of eclipse plugin development. Sadly, I don't have the time to work my way into this either, ATM.

@vorburger
Copy link
Member

@adangel fixed this in #255 (I think, re-open if NOK for you).

adangel added a commit that referenced this issue Sep 14, 2021
Use https everywhere

Fixes #251

Co-authored-by: Falko Modler <famod@users.noreply.github.com>
@adangel
Copy link
Member

adangel commented Sep 14, 2021

Fixed with f15dc18
With #255 only the build was fixed, but not the oomph setup file.

@famod
Copy link
Contributor Author

famod commented Nov 4, 2021

I'm afraid that even with 1.1.5.202109180907-r I'm getting a bintray entry, breaking updates etc.

oomph-setup:
oomph

sites
(the de-jcup ones are not related)

PS: Eclipse 2021-09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants