checkUnconfigurationRequired does not need old IMavenProjectFacade #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With m2e 1.12 the project configuration is batched, so if you use the old and new IMavenProjectFacade to compare your memory requirements are doubled. So as we check on unconfiguration whether any work needs to be done at all, we can just use the new state as a precondition.
erwint
force-pushed
the
reduce-memory-footprint
branch
from
a944aff
to
86443d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With m2e 1.12 the project configuration is batched, so if you use the
old and new IMavenProjectFacade to compare your memory requirements are
doubled. So as we check on unconfiguration whether any work needs to be
done at all, we can just use the new state as a precondition.