Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add draft PR instructions to PR template doc #1659

Merged
merged 1 commit into from
May 22, 2019

Conversation

benraskin92
Copy link
Collaborator

What this PR does / why we need it:

Update template PR doc to include draft PR link.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Contributor

@richardartoul richardartoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1659 into master will increase coverage by 6.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1659     +/-   ##
========================================
+ Coverage    65.3%   71.9%   +6.6%     
========================================
  Files         958     964      +6     
  Lines       80131   80663    +532     
========================================
+ Hits        52369   58056   +5687     
+ Misses      24080   18805   -5275     
- Partials     3682    3802    +120
Flag Coverage Δ
#aggregator 82.4% <ø> (-2.5%) ⬇️
#cluster 85.7% <ø> (+15.7%) ⬆️
#collector 63.9% <ø> (+8.7%) ⬆️
#dbnode 80.1% <ø> (+2.8%) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (+5.3%) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <ø> (+19%) ⬆️
#x 86.3% <ø> (+8.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca0202...31e01fb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1659 into master will increase coverage by 6.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1659     +/-   ##
========================================
+ Coverage    65.3%   71.9%   +6.6%     
========================================
  Files         958     964      +6     
  Lines       80131   80663    +532     
========================================
+ Hits        52369   58056   +5687     
+ Misses      24080   18805   -5275     
- Partials     3682    3802    +120
Flag Coverage Δ
#aggregator 82.4% <ø> (-2.5%) ⬇️
#cluster 85.7% <ø> (+15.7%) ⬆️
#collector 63.9% <ø> (+8.7%) ⬆️
#dbnode 80.1% <ø> (+2.8%) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (+5.3%) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <ø> (+19%) ⬆️
#x 86.3% <ø> (+8.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca0202...31e01fb. Read the comment docs.

@benraskin92 benraskin92 merged commit 8c0ef81 into master May 22, 2019
@justinjc justinjc deleted the braskin/update_PR_template branch July 12, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants