[query] Drop series with no values in the given range #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
========================================
- Coverage 71.8% 71.8% -0.1%
========================================
Files 970 970
Lines 81265 81268 +3
========================================
- Hits 58423 58421 -2
- Misses 19009 19012 +3
- Partials 3833 3835 +2
Continue to review full report at Codecov.
|
prateek
reviewed
May 31, 2019
| @@ -240,13 +240,21 @@ func parseQuery(r *http.Request) (string, error) { | |||
| return queries[0], nil | |||
| } | |||
|
|
|||
| func filterNaNSeries(series []*ts.Series) []*ts.Series { | |||
| func filterNaNSeries(series []*ts.Series, | |||
| start time.Time, | |||
There was a problem hiding this comment.
nit: rename to startInclusive and endInclusive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follows on from #1682 to also remove series with no NaN-values in the given range, as they were still appearing as empty series.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: