Add ability to set custom subscopes on response metrics. #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows clients to set a special header, M3-Custom-Response-Metrics-Scope, so that the response metrics can be created under the specified subscope. Subscopes will be re-used if the same subscope is specified across multiple requests.
arnikola
reviewed
May 26, 2021
| @@ -73,6 +77,13 @@ func ResponseMetrics(opts options.MiddlewareOptions) mux.MiddlewareFunc { | |||
| path = "unknown" | |||
| } | |||
|
|
|||
| customScopeName := r.Header.Get(headers.CustomResponseMetricsScope) | |||
| if customScopeName != "" { | |||
There was a problem hiding this comment.
nit: can potentially generalize the case without a header to go through the same path? Not necessarily worth bothering with though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows clients to set a special header, M3-Custom-Response-Metrics-Scope,
so that the response metrics can be created under the specified subscope.
Subscopes will be re-used if the same subscope is specified across multiple
requests.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: