etcd_docker 1: Refactor resources/docker package into resources/dockerexternal, resources/dockerm3, x/dockertest (#4145) #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
from
83353bd
to
3760195
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
2 times, most recently
from
0c71c18
to
c5b2c66
Compare
shaan420
approved these changes
Oct 18, 2022
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
from
3ca12fe
to
1326858
Compare
This was referenced Mar 14, 2023
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
from
1326858
to
747a40f
Compare
justinjc
approved these changes
Mar 22, 2023
…rexternal, resources/dockerm3, x/dockertest (#4145) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
from
747a40f
to
d3246b4
Compare
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1 of etcd test refactor
I am introducing a docker based etcd test framework. Overall structure I'm going for:
resources/dockerm3 -- m3 docker containers
resources/dockerexternal -- dependencies (prometheus, etcd)
The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here.
Stack: