etcd_docker 5: Incorporate docker based etcd approach into docker integration tests. #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
f2e9ce8
to
b5a283c
Compare
This was referenced Mar 14, 2023
justinjc
approved these changes
Mar 22, 2023
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
4e40e13
to
8277eef
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
b5a283c
to
0bdd1bf
Compare
andrewmains12
changed the title
andrewmains12
changed the base branch from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
to
master
andrewmains12
changed the title
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
0bdd1bf
to
e6f1295
Compare
andrewmains12
changed the base branch from
master
to
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
…egration tests. PR 5 for #4144 This PR makes the docker integration tests use containerized etcd. Previously, these relied on M3DB running an embbeded etcd server. There's no inherent need for this, and it opens us up to dependency issues as described in the linked github issue. Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those back at a later date.. commit-id:e67a5172
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
e6f1295
to
abd72e3
Compare
Base automatically changed from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
to
master
March 30, 2023 14:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 5 for #4144
This PR makes the docker integration tests use containerized etcd.
Previously, these relied on M3DB running an embbeded etcd server.
There's no inherent need for this, and it opens us up to dependency issues as described
in the linked github issue.
Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those
back at a later date..
Stack: