This repository has been archived by the owner on Feb 28, 2019. It is now read-only.
Port can now be suplied by env var #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 55.556% when pulling 8e33bb9cf83d01f4014fa10a400c1d3f799c0990 on port_by_env into 33570d8 on master. |
prateek
reviewed
Jun 21, 2017
services/m3ctl/main/main.go
Outdated
|
|
||
| if envPort != "" { | ||
| if p, err := strconv.Atoi(envPort); err == nil { | ||
| cfg.HTTP.Port = p |
There was a problem hiding this comment.
nit: log a message indicating you're overriding the config value with an env var
prateek
reviewed
Jun 21, 2017
services/m3ctl/main/main.go
Outdated
| } else { | ||
| logger.Fatalf("%s (%s) is not a valid port number", envPort, portEnvVar) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This check should be outside the else, i.e.
if envPort != "" {
...
}
if cfg.HTTP.Port == 0 {
...
}
prateek
reviewed
Jun 21, 2017
services/m3ctl/main/main.go
Outdated
| @@ -47,7 +55,7 @@ type serverConfig struct { | |||
| } | |||
|
|
|||
| // NewHTTPServerOptions create a new set of http server options. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things running in docker like to pass in ports to listen on. Adding this option.