This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Changing read logic for rulesets. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on unmarshalling json, will now use Mapping and Rollup Views. These views represent a state of ruleset ready to be looked at by a human on a screen.
dgromov
changed the title
prateek
reviewed
Sep 12, 2017
| @@ -160,6 +131,40 @@ func (mrs *mappingRuleSnapshot) Schema() (*schema.MappingRuleSnapshot, error) { | |||
| return res, nil | |||
| } | |||
|
|
|||
| // MappingRuleView is a human friendly representation of a mapping rule at a given point in time. | |||
| type MappingRuleView struct { | |||
There was a problem hiding this comment.
are you wrapping the struct access w/ methods to ensure the fields are immutable?
There was a problem hiding this comment.
Yes, but I kind of rather just make all the fields exposed. They can't be used for anything.
cw9
reviewed
Sep 15, 2017
| func newRollupTargetView(target RollupTarget) RollupTargetView { | ||
| return RollupTargetView{ | ||
| Name: string(target.Name), | ||
| Tags: stringArrayFromBytesArray(target.Tags), |
There was a problem hiding this comment.
nit: technically it's a slice not an array
There was a problem hiding this comment.
That naming convention was established before I started touching this code base. I can change it but would like to do that in a separate pr if possible.
rules/rollup.go
Outdated
| return RollupTarget{ | ||
| Name: []byte(rtv.Name), | ||
| Tags: bytesArrayFromStringArray(rtv.Tags), | ||
| Policies: rtv.Policies} |
rules/ruleset.go
Outdated
| return rollupRules | ||
| } | ||
|
|
||
| //UpdateMetadata contains descriptive information that needs to be updated |
There was a problem hiding this comment.
also move this outside of the sections where you define all the ruleSet methods? maybe closer to its constructor?
rules/ruleset.go
Outdated
| } | ||
| rs.updateMetadata(meta) | ||
| return nil | ||
| } | ||
|
|
||
| func (rs *ruleSet) DeleteMappingRule(d DeleteData) error { | ||
| m, err := rs.getMappingRuleByID(d.ID) | ||
| func (rs *ruleSet) DeleteMappingRule(ID string, meta UpdateMetadata) error { |
cw9
approved these changes
Sep 18, 2017
rules/ruleset.go
Outdated
| @@ -598,7 +612,7 @@ func (rs *ruleSet) ToMutableRuleSet() MutableRuleSet { | |||
| return rs | |||
| } | |||
|
|
|||
| // Schema returns the protobuf representation fo a ruleset | |||
| // Schema returns the protobuf representation fo a ruleset. | |||
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on unmarshalling json, will now use Mapping and
Rollup Views. These views represent a state of ruleset ready to be
looked at by a human on a screen.