Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package restructure #13

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Package restructure #13

wants to merge 16 commits into from

Conversation

mmihic
Copy link
Contributor

@mmihic mmihic commented Sep 7, 2016

Pulls each subsystem (cluster, mapping, conn) into its own package and provides better decoupling between them.

R: @robskillington @xichen2020

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage decreased (-1.2%) to 91.283% when pulling 12e8d6c on mmihic-package-restructure into dff8d0d on master.

rules.ClusterConfigUpdates = append(rules.ClusterConfigUpdates, &schema.ClusterConfigUpdateRule{
ClusterName: cname,
})
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test to cover this case?

@robskillington
Copy link

LGTM other than minor comment.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Matt Mihic seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants