Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat datasets/ directory with black #4

Closed
wants to merge 2 commits into from

Conversation

m4e7
Copy link
Owner

@m4e7 m4e7 commented Aug 18, 2023

Reformat select files (in particular, those changes in neuraloperator#186) in directory neuralop/datasets with black.

Previous PR: neuraloperator#199 (merged)

Reviewer: @JeanKossaifi

@JeanKossaifi
Copy link

I see this is marked as draft - looks good to me, shall we merge or do you want to add more to the PR?

@m4e7
Copy link
Owner Author

m4e7 commented Aug 20, 2023

I see this is marked as draft - looks good to me, shall we merge or do you want to add more to the PR?

That's just my bookkeeping while this PR is based on top of a non-main branch. I don't intend to add more to this PR.

Thanks for the LGTM!

@JeanKossaifi
Copy link

Thanks! Merged the other one, good to merge this?

@m4e7 m4e7 force-pushed the mogab/reformat-black-datasets branch from 78a0175 to f3a1632 Compare August 21, 2023 18:40
@m4e7 m4e7 changed the base branch from mogab/reformat-black to main August 21, 2023 18:41
@m4e7 m4e7 marked this pull request as ready for review August 21, 2023 18:41
@m4e7
Copy link
Owner Author

m4e7 commented Aug 25, 2023

Closed in favor of neuraloperator#205

@m4e7 m4e7 closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants