Reformat layers/ directory with black
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was finding it hard to read the slice notation in the `FactorizedSpectralConvNd.forward` implementations (i.e. where `out_fft[*] = self._contract(x[*], ...)`) for what's supposed to be the same slice `[*]`. Refactor each call to `self._contract` to use the same slice to index each tensor (i.e. to index `out_fft` and `x`).
Additionally, rename function arg `type` to `skip_type` to not overshadow builtin `type()`
|
@JeanKossaifi I've split formatting changes out from earlier commits here to reduce bloat in those PRs. I'll rebase #186 on top of this to clean it up. |
There was a problem hiding this comment.
Thanks @m4e7 looks good to me, just one comment about reqs.
requirements.txt
Outdated
| zarr | ||
| torch |
There was a problem hiding this comment.
@m4e7 the reason I hadn't included torch in the requirements is that typically users don't want to install it with pip (conda, Docker etc typically are better to handle CUDA installs) and this can cause issues particularly with pip -U where it may override existing install with wrong version.
There was a problem hiding this comment.
Aha, got it. I didn't realize that was a common user workflow. I've removed that line from requirements.txt
ziqi-ma
pushed a commit
to ziqi-ma/neuraloperator
that referenced
this pull request
Aug 29, 2023
Reformat `layers/` directory with `black`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat select files (in particular, those changes in #186) in directory
neuralop/layerswithblack.Additionally, add a "Contributing" section to the README, and state
blackas a formatting tool.