-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version properties #49
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 76.72% 76.82% +0.10%
==========================================
Files 17 17
Lines 3592 3612 +20
==========================================
+ Hits 2756 2775 +19
- Misses 836 837 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
45b369f
to
88de11a
Compare
Rewritten returning string instead of long, more readable and easy to compare in PHP |
88de11a
to
c8b946f
Compare
Perhaps time to raise minimal version ? to 9.1 ? RHEL-7 has 9.2, is >9 years old, and is close to its EOL in <1 year (I don't think something older exists) |
Added: factorization of version to string conversion (and fix from pr #48) |
Added: new properties are read only (PHP 8.1+) TODO: review all existing properties (not in the scope of this PR, another will follow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Remi and sorry for my latency!
The problem was about to be able to detect running server version to detect is json is available (the test is failing on RHEL-7 with libpq 9.2)
1st commit add 2 property to the Connection class
2nd commit use serverVersion to skip the new json test