Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix library version in PHPinfo #48

Closed
wants to merge 1 commit into from
Closed

fix library version in PHPinfo #48

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Collaborator

Without this

Used Library => Compiled => Linked
libpq => 14.3 => 14.0.3

With

Used Library => Compiled => Linked
libpq => 14.3 => 14.3

From documentation https://www.postgresql.org/docs/15/libpq-status.html

Applications might use this function to determine the version of the database server they are connected to. The result is formed by multiplying the server's major version number by 10000 and adding the minor version number. For example, version 10.1 will be returned as 100001, and version 11.0 will be returned as 110000. Zero is returned if the connection is bad.

Prior to major version 10, PostgreSQL used three-part version numbers in which the first two parts together represented the major version. For those versions, PQserverVersion uses two digits for each part; for example version 9.1.5 will be returned as 90105, and version 9.2.0 will be returned as 90200.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #48 (1670e79) into master (b86e51c) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   76.72%   76.71%   -0.02%     
==========================================
  Files          17       17              
  Lines        3592     3594       +2     
==========================================
+ Hits         2756     2757       +1     
- Misses        836      837       +1     
Impacted Files Coverage Δ
src/php_pq_module.c 95.45% <66.66%> (-4.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remicollet
Copy link
Collaborator Author

INcluded in pr #49
I keep this one open if you don't want the bigger one.

@remicollet remicollet mentioned this pull request Jun 13, 2023
@remicollet remicollet added the bug label Jun 13, 2023
@remicollet remicollet closed this Jun 15, 2023
@remicollet remicollet deleted the issue-libver branch June 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant