-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align device_tracker discovery between BLE and BT Classic #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.01%
==========================================
Files 89 89
Lines 2168 2171 +3
Branches 327 327
==========================================
+ Hits 1980 1983 +3
Misses 184 184
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
51982b5
to
5c0c860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this - I just requested a minor change for code quality reasons, otherwise this is all good!
src/integrations/bluetooth-classic/bluetooth-classic.service.ts
Outdated
Show resolved
Hide resolved
## [2.13.1](v2.13.0...v2.13.1) (2021-02-13) ### Bug Fixes * **bluetooth-classic:** align device_tracker discovery ([#493](#493)) ([9e1be95](9e1be95)) * **bluetooth-classic:** increase default interval ([ce64847](ce64847)), closes [#351](#351) * **bluetooth-low-energy:** interpret allowlist as strings ([7a442e1](7a442e1)), closes [#534](#534) * **bluetooth-low-energy:** retry on immediate disconnects ([37000b8](37000b8)), closes [#508](#508) * **entities:** do not refresh non-locked entities ([7c031d4](7c031d4)), closes [#532](#532)
🎉 This PR is included in version 2.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the change
Align device_tracker discovery for BT Classic integration. Happy to adjust as needed.
Note: I dont have any BT Classic devices to test this against. I have adapted jest test to validate device_tracker discovery logic.
Checklist
If you changed code:
npm test
)npm run format
)If you added a new integration:
docs/integrations/
docs/.vuepress/config.js
anddocs/integrations/README.md
Additional information
Is this PR related to any issues? Do you have anything else to add?
See #488 for details.