Align device_tracker discovery between BLE and BT Classic #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.01%
==========================================
Files 89 89
Lines 2168 2171 +3
Branches 327 327
==========================================
+ Hits 1980 1983 +3
Misses 184 184
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PeteBa
force-pushed
the
classic_device_tracker_discovery
branch
from
51982b5
to
5c0c860
Compare
PeteBa
changed the title
mKeRix
requested changes
Feb 5, 2021
src/integrations/bluetooth-classic/bluetooth-classic.service.ts
Outdated
Show resolved
Hide resolved
mKeRix
approved these changes
Feb 5, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2021
## [2.13.1](v2.13.0...v2.13.1) (2021-02-13) ### Bug Fixes * **bluetooth-classic:** align device_tracker discovery ([#493](#493)) ([9e1be95](9e1be95)) * **bluetooth-classic:** increase default interval ([ce64847](ce64847)), closes [#351](#351) * **bluetooth-low-energy:** interpret allowlist as strings ([7a442e1](7a442e1)), closes [#534](#534) * **bluetooth-low-energy:** retry on immediate disconnects ([37000b8](37000b8)), closes [#508](#508) * **entities:** do not refresh non-locked entities ([7c031d4](7c031d4)), closes [#532](#532)
|
🎉 This PR is included in version 2.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Align device_tracker discovery for BT Classic integration. Happy to adjust as needed.
Note: I dont have any BT Classic devices to test this against. I have adapted jest test to validate device_tracker discovery logic.
Checklist
If you changed code:
npm test)npm run format)If you added a new integration:
docs/integrations/docs/.vuepress/config.jsanddocs/integrations/README.mdAdditional information
Is this PR related to any issues? Do you have anything else to add?
See #488 for details.