Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add horizontal gap in suite selector #391

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: add horizontal gap in suite selector #391

merged 1 commit into from
Sep 6, 2024

Conversation

nastyastavitskaya
Copy link
Contributor

@nastyastavitskaya nastyastavitskaya commented Sep 4, 2024 •
edited
Loading

Summary

  • Updating suite selector cards with horizontal gaps.
Screenshot 2024-09-04 at 2 10 22 PM

Testing Plan

  • Was this tested locally? If not, explain why.
  • Run global navigation stories. Confirm that the suite selector has a horizontal gap between links.

@ilyusha
Copy link
Collaborator

ilyusha commented Sep 4, 2024

Review Forge

Click Here for AI Insights

@nastyastavitskaya nastyastavitskaya merged commit 74a43d0 into main Sep 6, 2024
11 of 12 checks passed
@nastyastavitskaya nastyastavitskaya deleted the fix/suite-selector-cards-gap branch September 6, 2024 17:41
mparticle-automation added a commit that referenced this pull request Sep 10, 2024
@mparticle-automation
chore(release): 1.30.2 [skip ci]
c97fad6 
## [1.30.2](v1.30.1...v1.30.2) (2024-09-10)

### Bug Fixes

* add horizontal gap in suite selector ([#391](#391)) ([74a43d0](74a43d0))
* Add Icons in Aquarium ([#395](#395)) ([d554ed5](d554ed5))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.30.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Sep 10, 2024
@mparticle-automation
chore(release): 1.31.0-chore-cascader-updates.2 [skip ci]
868095f 
# [1.31.0-chore-cascader-updates.2](v1.31.0-chore-cascader-updates.1...v1.31.0-chore-cascader-updates.2) (2024-09-10)

### Bug Fixes

* add horizontal gap in suite selector ([#391](#391)) ([74a43d0](74a43d0))
* add icons ([#399](#399)) ([3343c26](3343c26))
* Add Icons in Aquarium ([#395](#395)) ([d554ed5](d554ed5))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.31.0-chore-cascader-updates.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabyzif gabyzif gabyzif approved these changes

@tibuurcio tibuurcio Awaiting requested review from tibuurcio

Assignees
No one assigned
Labels
released on @chore released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nastyastavitskaya @ilyusha @mparticle-automation @gabyzif