-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Initial linting with ESLint [PR #3 - Linting and Formatting] #64
Closed
tibuurcio
wants to merge
3
commits into
style/initial-formatting-and-linting
from
style/initial-linting
Closed
style: Initial linting with ESLint [PR #3 - Linting and Formatting] #64
tibuurcio
wants to merge
3
commits into
style/initial-formatting-and-linting
from
style/initial-linting
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibuurcio
changed the title
style: Initial linting with ESLint
style: Initial linting with ESLint [PR #3 - Linting and Formatting]
Jan 16, 2024
This was referenced Jan 18, 2024
@tibuurcio make sure to update and commit the package-lock.json to fix the failing action oh didnt realize this is still on the outdated branch... |
We're keeping the discussions in #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
main
Summary
--fix
and manual ones. This should only be merged after style: Initial formatting with Prettier [PR #2 - Linting and Formatting] #63Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)
Related Content
Linting and Formatting - Unifying Initiative