Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Initial linting with ESLint [PR #3 - Linting and Formatting] #64

Closed

Conversation

tibuurcio
Copy link
Collaborator

@tibuurcio tibuurcio commented Jan 16, 2024

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Related Content

Linting and Formatting - Unifying Initiative

@tibuurcio tibuurcio changed the title style: Initial linting with ESLint style: Initial linting with ESLint [PR #3 - Linting and Formatting] Jan 16, 2024
@tibuurcio tibuurcio marked this pull request as ready for review January 16, 2024 14:50
@jared-dickman
Copy link
Collaborator

jared-dickman commented Jan 18, 2024

@tibuurcio make sure to update and commit the package-lock.json to fix the failing action Storybook Tests / Storybook Tests (push) Failing after 10s

oh didnt realize this is still on the outdated branch...

@tibuurcio
Copy link
Collaborator Author

We're keeping the discussions in #66

@tibuurcio tibuurcio closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants