-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Automated formatting and linting [PR #4 - Linting and Formatting] #66
Conversation
…b.com/mParticle/aquarium into feat/automated-formatting-and-linting
i switched from preferring the fragment is actually real jsx syntax, and you can add some special attributes to it, like a key, which can be useful instead of needing a "full div". also there are cases where you want to add a sibling element next to the component. the fragment allows this but the parens dont, because react elements can only support a single root node [which can be a fragment] to the point of it not being valid js syntax, i dont buy that one yet. for comparison, we dont do this
so why should we in jsx files?? i guess if prettier really really really thinks () are better than <></>, fine. we can try it. |
this looks gtg once the conflicts are resolved |
I will wait on #68 in order to fix everything just cause there should be some changes there as well |
# Conflicts: # package-lock.json # yarn.lock
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)