Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing MPIdentityErrorResponseCode values #181

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: Add missing MPIdentityErrorResponseCode values #181

merged 1 commit into from
Feb 8, 2023

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Add missing MPIdentityErrorResponseCode values

resolves #178

Testing Plan

  • Added unit test in Swift to ensure the new values are available as the original bug was due to Swift bridging.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 7afd66a into development Feb 8, 2023
@einsteinx2 einsteinx2 deleted the fix/SQDSDKS-5024-missing-identity-error-response-values branch February 8, 2023 17:38
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Feb 10, 2023
@mparticle-automation
chore(release): 8.11.2 [skip ci]
0739312 
## [8.11.2](v8.11.1...v8.11.2) (2023-02-10)

### Bug Fixes

* Add missing MPIdentityErrorResponseCode values ([#181](#181)) ([7afd66a](7afd66a))
* Add missing no location target for SPM ([#182](#182)) ([d265e8a](d265e8a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einsteinx2 @mparticle-automation @BrandonStalnaker