Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failed update-info parse crash (issue #1959) #1960

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

jdmcnair
Copy link
Contributor

Fixes issue described in #1959.

Description

Handles any Exception that takes place during the parsing of a response of a request to get update info.

Motivation and Context

Fixes issue described in #1959.

How Has This Been Tested?

I've tested it in the environment in which the bug was found (my corporate network).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated translation

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All Tests within VisualStudio are passing
  • This pull request does not target the master branch.
  • I have updated the changelog file accordingly, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jdmcnair
Copy link
Contributor Author

Looks like I have a failing CI check. Seems unlikely to have arisen from my changes:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants