Fix ApiControllerTests

ApiControllerTests were failing due to e537857.
maacpiash · Jul 15, 2020 · 9b3f32c · 9b3f32c
1 parent 63eea50
commit 9b3f32c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/tests/ApiControllerTests/FAHPController.test.cs b/tests/ApiControllerTests/FAHPController.test.cs
@@ -1,5 +1,7 @@
 using Xunit;
 using Microsoft.AspNetCore.Mvc;
+using Microsoft.Extensions.Logging;
+using Moq;
 using KonSchool.ApiControllers;
 
 namespace KonSchool.Tests.ApiControllerTests
@@ -9,17 +11,19 @@ public class FAHPControllerTests
         [Fact]
         public void Can_BadReq_OnInvalidParams()
         {
+			var mock = new Mock<ILogger<FAHPController>>();
             string not_really_numbers = "abcde";
-            var ctrlr = new FAHPController();
+            var ctrlr = new FAHPController(mock.Object);
             var result = ctrlr.Get(not_really_numbers);
             Assert.IsType<BadRequestObjectResult>(result.Result);
         }
 
         [Fact]
         public void Can_BadReq_OnNotEnoughNumbers()
         {
+			var mock = new Mock<ILogger<FAHPController>>();
             string not_enough_numbers = "1,2";
-            var ctrlr = new FAHPController();
+            var ctrlr = new FAHPController(mock.Object);
             var result = ctrlr.Get(not_enough_numbers);
             Assert.IsType<BadRequestObjectResult>(result.Result);
         }
@@ -29,18 +33,20 @@ public void Can_BadReq_OnNotEnoughNumbers()
         [InlineData("-20,1,1,1,1")]
         public void Can_BadReq_OnOutOfRangeNumbers(string weird_numbers)
         {
-            var ctrlr = new FAHPController();
+			var mock = new Mock<ILogger<FAHPController>>();
+            var ctrlr = new FAHPController(mock.Object);
             var result = ctrlr.Get(weird_numbers);
             Assert.IsType<BadRequestObjectResult>(result.Result);
         }
 
         [Fact]
         public void Can_Ok_OnValidParams()
         {
+			var mock = new Mock<ILogger<FAHPController>>();
             string numbers = "1,2,3,4,5";
-            var ctrlr = new FAHPController();
+            var ctrlr = new FAHPController(mock.Object);
             var result = ctrlr.Get(numbers);
             Assert.IsType<OkObjectResult>(result.Result);
         }
     }
-}
+}
diff --git a/tests/ApiControllerTests/SchoolsController.test.cs b/tests/ApiControllerTests/SchoolsController.test.cs
@@ -2,6 +2,8 @@
 using System.Linq;
 using System.Collections.Generic;
 using Microsoft.AspNetCore.Mvc;
+using Microsoft.Extensions.Logging;
+using Moq;
 using KonSchool.Models;
 using KonSchool.ApiControllers;
 using KonSchool.Tests.Mocks;
@@ -13,7 +15,8 @@ public class SchoolControllerTests
         [Fact]
         public void Can_Get_AllSchools()
         {
-            var ctrlr = new SchoolsController(new MockSchoolService());
+			var mock = new Mock<ILogger<SchoolsController>>();
+            var ctrlr = new SchoolsController(new MockSchoolService(), mock.Object);
             var response = ctrlr.Get();
             Assert.IsType<OkObjectResult>(response.Result);
             var AllSchools = (response.Result as OkObjectResult).Value as IEnumerable<School>;
@@ -23,7 +26,8 @@ public void Can_Get_AllSchools()
         [Fact]
         public void Can_Get_OneSchool_EIINwise()
         {
-            var ctrlr = new SchoolsController(new MockSchoolService());
+			var mock = new Mock<ILogger<SchoolsController>>();
+            var ctrlr = new SchoolsController(new MockSchoolService(), mock.Object);
             var response = ctrlr.GetOneSchool("1212");
             Assert.IsType<OkObjectResult>(response.Result);
             var OneSchool = (response.Result as OkObjectResult).Value as School;
@@ -33,7 +37,8 @@ public void Can_Get_OneSchool_EIINwise()
         [Fact]
         public void Can_Get_AllSchools_DivWise()
         {
-            var ctrlr = new SchoolsController(new MockSchoolService());
+			var mock = new Mock<ILogger<SchoolsController>>();
+            var ctrlr = new SchoolsController(new MockSchoolService(), mock.Object);
             var response = ctrlr.GetSchoolsByDivision("Dhaka");
             Assert.IsType<OkObjectResult>(response.Result);
             var resultValue = (response.Result as OkObjectResult).Value;
@@ -46,7 +51,8 @@ public void Can_Get_AllSchools_DivWise()
         [Fact]
         public void Can_Get_AllSchools_DisWise()
         {
-            var ctrlr = new SchoolsController(new MockSchoolService());
+			var mock = new Mock<ILogger<SchoolsController>>();
+            var ctrlr = new SchoolsController(new MockSchoolService(), mock.Object);
             var response = ctrlr.GetSchoolsByDistrict("Faridpur");
             Assert.IsType<OkObjectResult>(response.Result);
             var OneSchoolInFaridpur = (response.Result as OkObjectResult).Value as IEnumerable<School>;
@@ -57,7 +63,8 @@ public void Can_Get_AllSchools_DisWise()
         [Fact]
         public void Cannot_Get_NonexistentSchools()
         {
-            var ctrlr = new SchoolsController(new MockSchoolService());
+			var mock = new Mock<ILogger<SchoolsController>>();
+            var ctrlr = new SchoolsController(new MockSchoolService(), mock.Object);
 
             // EIIN wise
             var response_EIIN = ctrlr.GetOneSchool("2121");