add tests and fix for socketcluster create A-Project-Like-This

maarteNNNN · Jan 19, 2023 · d93d318 · d93d318
1 parent a3bbeff
commit d93d318
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -341,7 +341,7 @@ class REPLClient {
          */
         if (typeof accumulator.execute === 'function' && !currentValue) {
           await accumulator.execute.call(this, {
-            argument: this.camelCaseToKebab(currentValue),
+            argument: commands[i],
             options,
           });
           if (this.options.interactive) break;
@@ -368,7 +368,7 @@ class REPLClient {
               !accumulator[currentValue].hasOwnProperty('execute')
             ) {
               await accumulator.execute.call(this, {
-                argument: this.camelCaseToKebab(currentValue),
+                argument: commands[i],
                 options,
               });
               if (this.options.interactive) break;
@@ -416,7 +416,7 @@ class REPLClient {
              */
             if (typeof accumulator.execute === 'function') {
               await accumulator.execute.call(this, {
-                argument: this.camelCaseToKebab(currentValue),
+                argument: commands[i],
                 options,
               });
               break;

diff --git a/test/cli.test.js b/test/cli.test.js
@@ -354,4 +354,51 @@ describe('REPL Client tests', () => {
         .to.be.eql('command is invalid and needs more arguments');
     }
   });
+
+  it('it prevents a project name from translating into camelCase with execute', async () => {
+    const projectName = 'Pyaterochka-013152-SKU-auditor';
+    try {
+      const testCli = await initiateCli(
+        { ...exampleOptions },
+        {
+          _: ['create', projectName],
+        },
+      );
+
+      const commands = {
+        create: {
+          execute: ({ argument, options }) => {
+            chai.expect(argument).to.be.eql(projectName);
+          },
+          help: 'test this help',
+        },
+      };
+
+      await testCli.run(commands);
+    } catch (e) {
+      chai.expect(e).to.not.throw();
+    }
+  });
+
+  it("it's unable to pass an argument without execute, that would just be a nested command", async () => {
+    const projectName = 'Pyaterochka-013152-SKU-auditor';
+    try {
+      const testCli = await initiateCli(
+        { ...exampleOptions },
+        {
+          _: ['create', projectName],
+        },
+      );
+
+      const commands = {
+        create: ({ argument, options }) => {},
+      };
+
+      await testCli.run(commands);
+    } catch (e) {
+      chai
+        .expect(e.message)
+        .to.be.eql('command is invalid and needs more arguments');
+    }
+  });
 });