V0.4.x #8
V0.4.x #8
Conversation
…rng seed option to allow regression testing.
…inor changes to argument checking
…der and image access
…e; Use setuptools to install executable script; Add manual install with Makefile
|
Holy Moly Ron, that's some serious work that you've put in! Thanks for sharing! We'll need a bit of time to parse your improvements - also this is the first time I'm dealing with such an extensive pull request ;) |
shutil.copytree() doesn't handle single files so treat files and directories separately.
Avoid some of the bloat in the docker image mainly by not installing fsl recommended dependencies .
|
Implemented the feature_time_series refactoring. Great speed improvement associated. Many thanks! |
|
Hi @maartenmennes and @rtrhd , is there a roadmap to merge this PR? I believe it is awesome work from @rtrhd , but I am not sure if it is finished. Please let me know if I can help developing/testing to merge it to the main repo! Thank you |
|
Hi @anibalsolon, many thanks for your input. I too believe it's great work by @rtrhd, but the changes are so massive that I really need to take my time to go through them. Unfortunately, I don't see that planned for the immediate future... |
Hi,
I've been maintaining an optimised python2/3 fork of ICA-AROMA for use in the Bristol University CRIC imaging centre for a while now. I've also added some regression tests against your current version, updated the documentation and made it installable as a python package. You may well not want to consider merging this branch as it stands since the commit history could do with squashing and there is quite a large change in the layout of the repo but let me know if it is any use to you and I can squash/rebase if required.
All the Best,
Ron Hartley-Davies