package: setup.py and reorganize #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using rtrhd/ICA-AROMA as a template
setup.py can use new function as "console_scripts" get_data_path() is used instead of abspath(__file__) because the script location is no longer the module/data location
Makefile to run tests (and get data for tests) 🐛 also bug fix with "argv.pop" for ica_aroma_cli argv=sys.argv change
WillForan
changed the title
setup.py and move files around to make pip installable package
Fixed pd.concat syntax for classification_plots.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the fork from @rtrhd (#8 ) as a template for packaging, but it does not update the internal structure. Hopefully it can be easily audited and pulled -- if moving toward a pypi installation is in the roadmap (issue #38).
ICA_AROMA.pyandICA_AROMA_functions.pywere renamed and moved inside the package directory.ICA_AROMA.pyis now nested inside a massive function. Most of the changes are just an indent from this. Seegit diff -w --word-diff=color f1358e0 7e491a7 -- ica_aroma/ica_aroma.pyfor a clean view of the changes__init__.pyexists with a function to find the module path where*_mask.nii.gzwill reside.ICA_AROMA.py(nowica_aroma/ica_aroma.py) needed two changes to be packaged:__file__, we use the module path (__init__.py:get_data_path())sys.argvinto the new primary function. I thinkargv.popneeds to be run after initializing the parser to keep the script nameargv[0]from being used as a script argument.pytest) for the two changes are intests/tests_run.py.There's aMakefilefor setup. (make test), usingrefininput images from @rtrhdthe branch can be installed with pip like