select-vision: fix state when none vision is selected

macabeus · Jun 9, 2019 · b926a5f · b926a5f
1 parent 7c76399
commit b926a5f
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/brush/src/components/SelectVision/index.js b/brush/src/components/SelectVision/index.js
@@ -5,19 +5,29 @@ import ROMContext from '../../context/ROMContext'
 
 const SelectVision = () => {
   const { romBufferMemory } = useContext(ROMContext)
-  const { updateVision, visionIndex, visionWorld } = useContext(VisionContext)
+  const {
+    updateVision,
+    vision: { state: visionState },
+    visionIndex,
+    visionWorld,
+  } = useContext(VisionContext)
 
   const setNewVision = (newVision) => {
     const [newVisionWorld, newVisionIndex] = newVision.split('-')
 
     updateVision(romBufferMemory, newVisionWorld, newVisionIndex)
   }
 
+  const dropdownValue = visionState === 'noSelected' ?
+    '' :
+    `${visionWorld}-${visionIndex}`
+
   return (
     <Dropdown
       name="selectVision"
+      placeholder="Select a vision"
       onChange={e => setNewVision(e.target.value)}
-      value={`${visionWorld}-${visionIndex}`}
+      value={dropdownValue}
       options={[{ name: 'Vision 1-1', value: '1-1' }, { name: 'Vision 1-2', value: '1-2' }]}
     />
   )