Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grouping for interfaces #193

Merged
merged 18 commits into from Feb 28, 2022
Merged

feat: add grouping for interfaces #193

merged 18 commits into from Feb 28, 2022

Conversation

snapre
Copy link
Member

@snapre snapre commented Jan 15, 2022

@snapre snapre marked this pull request as ready for review January 15, 2022 15:11
@snapre snapre changed the title feat: add grouping for scenes and interfaces WIP feat: add grouping for scenes and interfaces Jan 15, 2022
@snapre snapre marked this pull request as draft January 15, 2022 16:06
@zivyangll
Copy link
Member

@snapre Thank you very much for your PR. We have been looking forward to this feature for a long time. The amount of code is a bit large. We will review it as soon as possible

@paradite
Copy link
Collaborator

Impressive PR! This change is very big and it would take a while to go through.
Also, when would this be out of WIP and ready for review?

@snapre snapre changed the title WIP feat: add grouping for scenes and interfaces feat: add grouping for scenes and interfaces Jan 21, 2022
@snapre snapre marked this pull request as ready for review January 21, 2022 13:01
@snapre
Copy link
Member Author

snapre commented Jan 21, 2022

@paradite Ready :)

@snapre snapre changed the title feat: add grouping for scenes and interfaces feat: add grouping for interfaces Feb 28, 2022
@xudafeng xudafeng merged commit 3170d03 into master Feb 28, 2022
@xudafeng xudafeng deleted the feat/add_grouping branch February 28, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants