-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: diff coverage #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudafeng
reviewed
Dec 7, 2020
lib/collector.js
Outdated
* @param {Object} options Optional. Configuration options. | ||
* @param {Store} options.store - an implementation of `Store` to use for temporary | ||
* calculations. | ||
*/ | ||
function Collector(options) { | ||
options = options || {}; | ||
this.store = options.store || new MemoryStore(); | ||
this.incrementalFilesMap = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
xudafeng
reviewed
Dec 7, 2020
lib/report/html.js
Outdated
const indexFile = path.resolve(dir, 'index.html'); | ||
|
||
if (this.opts.verbose) { | ||
console.error('Writing ' + indexFile); | ||
} | ||
|
||
writer.writeFile(indexFile, (contentWriter) => { | ||
this.writeIndexPage(contentWriter, node); | ||
// TODO 处理首屏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
ColaDaddyz
force-pushed
the
feat/diff-coverage
branch
from
December 7, 2020 13:54
99a69a3
to
07a688e
Compare
feat: remove unused code feat: rm todo
ColaDaddyz
force-pushed
the
feat/diff-coverage
branch
from
December 7, 2020 14:07
07a688e
to
626069f
Compare
xudafeng
force-pushed
the
feat/diff-coverage
branch
from
December 7, 2020 15:01
8337d04
to
7cf4caf
Compare
xudafeng
force-pushed
the
feat/diff-coverage
branch
from
December 8, 2020 09:13
5bc061c
to
b03a316
Compare
* chore: fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.