Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Support #21

Open
Tracked by #35
yesBad opened this issue Dec 29, 2023 · 13 comments
Open
Tracked by #35

Docker Support #21

yesBad opened this issue Dec 29, 2023 · 13 comments
Assignees
Labels
feature request New feature or modification to existing feature help wanted Extra attention is needed in progress Issue is currently being addressed
Milestone

Comments

@yesBad
Copy link

yesBad commented Dec 29, 2023

Hi there! Looks like a wonderful new software. I saw you already had some thoughts about this, just decided it could be added here as an issue.

I also wonder, how have you thought about this exactly? As currently one could make a simple image with NoVNC and make the app accessable via WebUI. The firewall stuff wouldn't work, but otherwise it would probably work.

I will personally take a look at spinning some dockerization with NoVNC. And leave some stuff about it here for those interested.

@macarooni-man macarooni-man self-assigned this Dec 29, 2023
@macarooni-man macarooni-man added help wanted Extra attention is needed feature request New feature or modification to existing feature labels Dec 29, 2023
@BoberMod BoberMod mentioned this issue Dec 29, 2023
@macarooni-man
Copy link
Owner

macarooni-man commented Dec 29, 2023

Hi there! Looks like a wonderful new software. I saw you already had some thoughts about this, just decided it could be added here as an issue.

I also wonder, how have you thought about this exactly? As currently one could make a simple image with NoVNC and make the app accessable via WebUI. The firewall stuff wouldn't work, but otherwise it would probably work.

I will personally take a look at spinning some dockerization with NoVNC. And leave some stuff about it here for those interested.

Hello! Thanks for posting an issue, I like your idea a lot! The main dilemma I've had with this is the accessibility of install, and the efficacy of a WebUI.

NoVNC was my solution as well, though I'm still pondering how to make a streamlined setup for the end user to decide whether they want that feature or not. Some people wouldn't want the added complexity of a Docker installation along with an exposed WebUI.

@macarooni-man macarooni-man added this to the v2.1 milestone Dec 29, 2023
@macarooni-man macarooni-man pinned this issue Dec 30, 2023
@yesBad
Copy link
Author

yesBad commented Dec 30, 2023

I have made a working NoVNC powered docker build of auto-mcs, source for the Dockerfile & extras are available at: https://github.com/yesBad/auto-mcs/tree/docker

If you would like to test it out, please feel free to do so as I have published a ghcr.io image: ghcr.io/yesbad/auto-mcs:novnc
docker-compose is like so; https://github.com/yesBad/auto-mcs/blob/docker/docker-compose.yml

This dockerization I've done requires you to have "non root" Docker install, which is basically the basic stuff nowdays gladly.

Screenshot_20231230_151324

If your auto-mcs never starts, stop the container, then run chown -R 1000:1000 data as a root user.

(data folder by default as set in docker compose)

Please do not expose the NoVNC to public, it is in no way secure.. Keep it local & only for you!
This is only for testing & development, it is very uh shitty implementation, but it works! :D

@devsoleo
Copy link

Works great ! Doing the chown command seems to be necessary for this to work !
image

@yesBad
Copy link
Author

yesBad commented Dec 30, 2023

Yeah setting the UID & GID to 1000 is necessary.

@pinkyplant
Copy link

In Linuxserver.io docker images, there is options to set this. See below.
--- version: "2.1" services: qbittorrent: image: lscr.io/linuxserver/qbittorrent:latest container_name: qbittorrent environment: - PUID=1000 - PGID=1000 - TZ=Etc/UTC - WEBUI_PORT=8080 volumes: - /path/to/appdata/config:/config - /path/to/downloads:/downloads ports: - 8080:8080 - 6881:6881 - 6881:6881/udp restart: unless-stopped
Maybe we add this way? I am currently researching how this is done

@pinkyplant
Copy link

See This

@yesBad
Copy link
Author

yesBad commented Jan 3, 2024

In Linuxserver.io docker images, there is options to set this. See below. --- version: "2.1" services: qbittorrent: image: lscr.io/linuxserver/qbittorrent:latest container_name: qbittorrent environment: - PUID=1000 - PGID=1000 - TZ=Etc/UTC - WEBUI_PORT=8080 volumes: - /path/to/appdata/config:/config - /path/to/downloads:/downloads ports: - 8080:8080 - 6881:6881 - 6881:6881/udp restart: unless-stopped Maybe we add this way? I am currently researching how this is done

Eh kind of useless, but I guess it could be nice QOL.

@pinkyplant
Copy link

pinkyplant commented Jan 3, 2024 via email

@tarosbubbletea
Copy link

I have made a working NoVNC powered docker build of auto-mcs...

By the way there's no file picker package installed in the container, so the "importing external servers" feature is broken
image

@yesBad
Copy link
Author

yesBad commented Feb 8, 2024

Yeah I'm aware a couple features are borked. (i.e all that open the file manager or ask for file etc)

@macarooni-man
Copy link
Owner

I have made a working NoVNC powered docker build of auto-mcs...

By the way there's no file picker package installed in the container, so the "importing external servers" feature is broken

@tarosbubbletea do you by chance have any suggestions on how to get a file picker to be passed through to the host?

@yesBad
Copy link
Author

yesBad commented Feb 9, 2024

I'll be releasing WIP file support and the env UID/GID next week

EDIT; I've been 'optimizing' the "working parts" of the software and haven't done any new stuff yet.... this week tho right :)?

@macarooni-man macarooni-man added the in progress Issue is currently being addressed label Apr 3, 2024
@macarooni-man macarooni-man unpinned this issue Jul 17, 2024
@macarooni-man macarooni-man modified the milestones: v2.1, v2.2 Jul 17, 2024
@pinkyplant
Copy link

Any updates on this? And would it maybe be possible to move the forked repository to a branch here for making it easier to find and QoL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or modification to existing feature help wanted Extra attention is needed in progress Issue is currently being addressed
Projects
None yet
Development

No branches or pull requests

5 participants