Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of LIMIT / OFFSET in queries with the IN condition #387

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

macbre
Copy link
Owner

@macbre macbre commented Apr 20, 2023

Resolves #382

@macbre macbre added the bug label Apr 20, 2023
@macbre macbre marked this pull request as ready for review April 20, 2023 16:14
@macbre macbre requested a review from collerek as a code owner April 20, 2023 16:14
@macbre macbre enabled auto-merge (squash) April 20, 2023 16:14
Only handle the punctuation when we already have the LIMIT keyword parsed. From now on IN(a,b,c) condition should not mess with it.
@macbre macbre force-pushed the fix/limit-and-offset-with-in-condition branch from 9dfb994 to fbbfa16 Compare April 20, 2023 16:16
@macbre macbre merged commit 1c20ba1 into master Apr 20, 2023
8 checks passed
@macbre macbre deleted the fix/limit-and-offset-with-in-condition branch April 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit_and_offset method bug?
1 participant