Change multipart handling to check for object#read instead of specific object types #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ERIMENTAL" This reverts commit 4a34a80.
…g for specific object types
maccman
added a commit
that referenced
this pull request
Mar 28, 2013
Change multipart handling to check for object#read instead of specific object types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows passing params[:file] in a Rails 3.2 upload directly into Nestful's post function (Rails 3.2 wraps the uploaded file in yet another object type). Really all we need to know is whether the object responds to read, in other words; does it act like a StringIO object?
The changeset has a bunch of deleted whitespace because SublimeText strips extra whitespace out of blank lines automatically.
Edit: I just saw that this pull request has two unnecessary commits (which don't change anything, overall). Feel free to reject it and make the changes yourself in a cleaner way if you prefer.