This repository has been archived by the owner on May 2, 2023. It is now read-only.
enable discovery on all network interfaces #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have WiFi, LAN and several VPNs and the plugin does not work = doesn't find the printer. Luban works well so it had to be something different than what you mention in Troubleshooting Snapmaker Discovery.
It appears that QHostAddress.SpecialAddress.AnyIPv4 (or simply not binding the socket to particular interface) picks any (=the first reported by OS) but not all of them! So if someone has multiple network interfaces the program must loop through all of them. And that's what Luban actually does as you can see at https://github.com/Snapmaker/Luban/blob/master/src/server/services/socket/WifiServerManager.js#L79
So I have modified your code to do it as well. I had it fixed for several month (for Cura 4), today I adapted the change for QNetwork so it's ready for Cura 5.